From: Sean Anderson <sean.anderson@seco.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
Linus Walleij <linus.walleij@linaro.org>,
Jules Maselbas <jmaselbas@kalray.eu>,
Felipe Balbi <balbi@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH v2 2/4] usb: phy: generic: Get the vbus supply
Date: Mon, 25 Apr 2022 13:14:09 -0400 [thread overview]
Message-ID: <20220425171412.1188485-3-sean.anderson@seco.com> (raw)
In-Reply-To: <20220425171412.1188485-1-sean.anderson@seco.com>
While support for working with a vbus was added, the regulator was never
actually gotten (despite what was documented). Fix this by actually
getting the supply from the device tree.
Fixes: 7acc9973e3c4 ("usb: phy: generic: add vbus support")
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
(no changes since v1)
drivers/usb/phy/phy-generic.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index 661a229c105d..34b9f8140187 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b/drivers/usb/phy/phy-generic.c
@@ -268,6 +268,13 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop)
return -EPROBE_DEFER;
}
+ nop->vbus_draw = devm_regulator_get_exclusive(dev, "vbus");
+ if (PTR_ERR(nop->vbus_draw) == -ENODEV)
+ nop->vbus_draw = NULL;
+ if (IS_ERR(nop->vbus_draw))
+ return dev_err_probe(dev, PTR_ERR(nop->vbus_draw),
+ "could not get vbus regulator\n");
+
nop->dev = dev;
nop->phy.dev = nop->dev;
nop->phy.label = "nop-xceiv";
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2022-04-25 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 17:14 [PATCH v2 0/4] usb: phy: generic: Support enabling/disabling VBUS Sean Anderson
2022-04-25 17:14 ` [PATCH v2 1/4] dt-bindings: usb: usb-nop-xceiv: Repurpose vbus-regulator Sean Anderson
2022-04-25 20:26 ` Linus Walleij
2022-04-25 17:14 ` Sean Anderson [this message]
2022-04-25 17:14 ` [PATCH v2 3/4] usb: phy: generic: Implement otg->set_vbus Sean Anderson
2022-04-25 17:14 ` [PATCH v2 4/4] usb: phy: generic: Disable vbus on removal Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425171412.1188485-3-sean.anderson@seco.com \
--to=sean.anderson@seco.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmaselbas@kalray.eu \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.